Undo externing of floats / variables / strings#559
Conversation
|
2 participants
{{ message }}
Merged
JoshSanch merged 1 commit intobfbbdecomp:mainfrom May 22, 2025
Merged
JoshSanch
approved these changes
May 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My motivation for doing this is that for my Ghidra import to work I need more files to be temporarily marked as Matching so that additional detailed symbol info is included in the linked executable I dump from. But many of these externed symbols cause linking to fail when it would otherwise succeed. I don't think there's any remaining need to keep these things externed now that we have objdiff to work with so I've done the following:
Un-extern various floats, placing them directly inline in the source code and fixing them to be bit-accurate where appropriate (they didn't match the purported value in the comment in the last digit in some cases).
Un-extern various local / global variables, placing them in the appropriate part of the data section depending on whether they're zero initialized, uninitialized, or initialized with a value.
Make various externed string constants static so that they don't conflict if the files they're in are changed to Matching in configure.py.